Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop 2.12 support, add scalafmt, scalafix, MiMa #165

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

migesok
Copy link
Contributor

@migesok migesok commented Sep 3, 2024

Source and binary compat preserved.

The code changes:

  • scalafmt and scalafix formatting applied
  • added type annotations to public members and implicits
  • migrated to Scala 3 syntax for imports
  • since 2.12 is not supported anymore, replaced CurrentThreadExecutionContext wrapper with direct usage of ExecutionContext.parasitic. This as well leads to removal of the direct dependency on executor-tools as it is not used in the project anymore.

@coveralls
Copy link

coveralls commented Sep 3, 2024

Pull Request Test Coverage Report for Build 10680242506

Details

  • 15 of 22 (68.18%) changed or added relevant lines in 8 files are covered.
  • 14 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.7%) to 85.514%

Changes Missing Coverage Covered Lines Changed/Added Lines %
sequentially-metrics/src/main/scala/com/evolutiongaming/concurrent/SequentiallyMetrics.scala 0 1 0.0%
sequentially/src/main/scala/com/evolutiongaming/concurrent/sequentially/SequentiallyAsync.scala 2 3 66.67%
sequentially-metrics/src/main/scala/com/evolutiongaming/concurrent/MeteredSequentiallyAsync.scala 0 5 0.0%
Files with Coverage Reduction New Missed Lines %
sequentially/src/main/scala/com/evolutiongaming/concurrent/sequentially/Sequentially.scala 1 92.86%
benchmark/src/main/scala/com/evolutiongaming/concurrent/sequentially/SequentiallyBenchmark.scala 1 0.0%
sequentially-metrics/src/main/scala/com/evolutiongaming/concurrent/MeteredSequentiallyAsync.scala 1 0.0%
benchmark/src/main/scala/com/evolutiongaming/concurrent/sequentially/SequentiallyHandlerBenchmark.scala 2 0.0%
benchmark/src/main/scala/com/evolutiongaming/concurrent/sequentially/SequentiallyAsyncBenchmark.scala 2 0.0%
benchmark/src/main/scala/com/evolutiongaming/concurrent/sequentially/SequentiallyStreamBenchmark.scala 2 0.0%
sequentially-metrics/src/main/scala/com/evolutiongaming/concurrent/SequentiallyMetrics.scala 5 0.0%
Totals Coverage Status
Change from base Build 9446050682: 0.7%
Covered Lines: 183
Relevant Lines: 214

💛 - Coveralls

Source and binary compat preserved.

The code changes:
- scalafmt and scalafix formatting applied
- added type annotations to public members and implicits
- migrated to Scala 3 syntax for imports
- since 2.12 is not supported anymore, replaced CurrentThreadExecutionContext wrapper with direct usage of ExecutionContext.parasitic. This as well leads to removal of the direct dependency on executor-tools as it is not used in the project anymore.
@migesok migesok force-pushed the feature/upgrade-build branch from 5943233 to 5514a4d Compare September 3, 2024 09:26
@migesok migesok merged commit 566ce7f into master Sep 3, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants