Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EAK-359] Added Javadoc; minor coding changes #476

Merged
merged 12 commits into from
Jul 27, 2023

Conversation

smiakchilo
Copy link
Collaborator

No description provided.

@smiakchilo smiakchilo added documentation Improvements or additions to documentation AEM AEM-specific competencies are involved labels Jul 27, 2023
Comment on lines 28 to 29
* Represents a mix-in object used with {@link AbstractAdapter}-based objects to expose Java objects leveraging
* reflective operations to
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to understand this sentence 5 times but failed to do so)
perhaps it can be rewritten to be more human-readable?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks) It was a glitch. a broken phrase

/**
* Called by {@link InterfaceHandler#toString()} to convert the given array to a string representation
* @param array The array to convert
* @return A string representation of the array; can be an empty string but never {@code null}
Copy link
Collaborator

@liubou-masiuk liubou-masiuk Jul 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be an empty string

I don't see how this can be true with the current implementation of this method....

smiakchilo and others added 8 commits July 27, 2023 14:10
Co-authored-by: liubou-masiuk <54947899+liubou-masiuk@users.noreply.github.com>
Co-authored-by: liubou-masiuk <54947899+liubou-masiuk@users.noreply.github.com>
Co-authored-by: liubou-masiuk <54947899+liubou-masiuk@users.noreply.github.com>
Co-authored-by: liubou-masiuk <54947899+liubou-masiuk@users.noreply.github.com>
Co-authored-by: liubou-masiuk <54947899+liubou-masiuk@users.noreply.github.com>
@smiakchilo smiakchilo merged commit c4de2c5 into develop Jul 27, 2023
5 checks passed
@smiakchilo smiakchilo deleted the feature/EAK-359-javadoc branch July 27, 2023 11:40
@github-actions github-actions bot locked and limited conversation to collaborators Jul 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
AEM AEM-specific competencies are involved documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants