Skip to content
This repository has been archived by the owner on Aug 15, 2024. It is now read-only.

Use setup-rails for CI? #185

Merged
merged 3 commits into from
Nov 7, 2023
Merged

Conversation

andyw8
Copy link
Contributor

@andyw8 andyw8 commented Apr 16, 2022

👋

I recently published setup-rails, a reusable GitHub CI workflow:

https://www.andywaite.com/2022/04/15/reusable-github-actions-rails-workflow.html

I'm hoping this would be a useful addition to Jumpstart. Here's an example of it in use:

http://github.com/andyw8/jumpstart-setup-rails

(I had to make a small adjustment to the fixtures).

I understand that not everyone wants to use GitHub Actions, but the file would have no effect if running on another CI platforms.

template.rb Show resolved Hide resolved
@excid3
Copy link
Owner

excid3 commented Nov 7, 2023

This is great @andyw8. Meant to get to this way sooner, but better late than never!

@excid3 excid3 merged commit 74f6fa3 into excid3:master Nov 7, 2023
1 check passed
@excid3
Copy link
Owner

excid3 commented Nov 7, 2023

RE: the fixtures changes, should we override the fixtures file? Right now we're just using the fixtures file that Devise generates.

Probably should have done this before merging, but YOLO!

@andyw8
Copy link
Contributor Author

andyw8 commented Nov 10, 2023

@excid3 would you be interested in using this on Jumpstart Pro?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants