Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance module api #286

Closed
wants to merge 15 commits into from
Closed

Enhance module api #286

wants to merge 15 commits into from

Conversation

banditopazzo
Copy link
Member

@banditopazzo banditopazzo commented May 14, 2024 •
edited
Loading

Enhance module api

New features:

  • modules can have custom initialization fields
  • add methods to module trait
  • move module loops inside module manager

ref: #157

@banditopazzo banditopazzo force-pushed the module_api_refactoring_2 branch 4 times, most recently from 381b59e to 128b6ae Compare May 14, 2024 16:57
@banditopazzo banditopazzo added the enhancement New feature or request label May 14, 2024
@banditopazzo banditopazzo self-assigned this May 14, 2024
@banditopazzo banditopazzo force-pushed the module_api_refactoring_2 branch 3 times, most recently from 51d5c0c to 15dba1d Compare May 15, 2024 16:49
@banditopazzo banditopazzo changed the title feat: move module loops inside module manager enhance modules api 2/2 May 15, 2024
@banditopazzo banditopazzo changed the base branch from module_api_refactoring_1 to main May 15, 2024 17:37
@banditopazzo banditopazzo mentioned this pull request May 15, 2024
Closed
@banditopazzo banditopazzo changed the title enhance modules api 2/2 Enhance module api May 15, 2024
vadorovsky
vadorovsky reviewed May 20, 2024
View reviewed changes
Copy link
Member

@vadorovsky vadorovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this change in general! Having a trait is so much cleaner than having the Module struct. Left some nit comments, but I will give it a second look soon.

crates/modules/logger/src/lib.rs Show resolved Hide resolved
crates/modules/logger/src/lib.rs Show resolved Hide resolved
vadorovsky
vadorovsky reviewed May 27, 2024
View reviewed changes
Copy link
Member

@vadorovsky vadorovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no other comments than my previous nits, the code looks good to me.

I could re-review after we get #288 merged, but overall I like the direction and I don't think I'm going to have any not nitpicky remarks.

@banditopazzo banditopazzo force-pushed the module_api_refactoring_2 branch 3 times, most recently from 771062d to 188bcf6 Compare June 12, 2024 12:07
@banditopazzo banditopazzo marked this pull request as ready for review June 16, 2024 16:38
@banditopazzo banditopazzo reopened this Sep 18, 2024
@banditopazzo banditopazzo mentioned this pull request Sep 18, 2024
Merged
@banditopazzo
Copy link
Member Author

Closed in favor of #313 because this PR was impossible to merge due to Github Issue https://github.com/orgs/community/discussions/27521

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadorovsky vadorovsky vadorovsky approved these changes

Assignees

@banditopazzo banditopazzo

Labels
API breaking change enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@banditopazzo @vadorovsky