Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Allow to provide arguments through cargo xtask test #308

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

vadorovsky
Copy link
Member

The main motivation is the ability to specify a pattern for tests to run together with architest. Example command:

cargo xtask test --target x86_64-unknown-linux-musl \
    --features all-vendored --features tls-rustls \
    --kernel-versions 6.3 --force-architest \
    -- dns

The main motivation is the ability to specify a pattern for tests to
run together with architest. Example command:

```
cargo xtask test --target x86_64-unknown-linux-musl \
    --features all-vendored --features tls-rustls \
    --kernel-versions 6.3 --force-architest \
    -- dns
```
Copy link
Member

@banditopazzo banditopazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please do also the changes to the test-suite binary to handle the args, it seems that at this state it remains unused

@vadorovsky
Copy link
Member Author

please do also the changes to the test-suite binary to handle the args, it seems that at this state it remains unused

I don't think any change is needed there. Passing arguments to test-suite is already supported:

 sudo -E ./target/release/test-suite exec_updates_interest

running 1 test
test filtering::exec_updates_interest ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 40 filtered out; finished in 0.22s

We just weren't exposing this functionality in xtask. This PR is only about being able to pass arguments to test-suite when using QEMU/architest.

Copy link
Member

@banditopazzo banditopazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My mistake, you are right I found it

@vadorovsky vadorovsky merged commit d9a5f99 into main Jul 4, 2024
21 checks passed
@vadorovsky vadorovsky deleted the vadorovsky/xtask-test-arguments branch July 4, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants