update hyper axum #322
Merged
update hyper axum #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
banditopazzo
force-pushed
the
234-update-hyper-axum
branch
from
88f8b3e to
2a01d1a
Compare
|
tokio-rs/axum#2941 was merged, but |
banditopazzo
force-pushed
the
234-update-hyper-axum
branch
from
2a01d1a to
e1c22bc
Compare
banditopazzo
force-pushed
the
234-update-hyper-axum
branch
from
e1c22bc to
78d50c9
Compare
|
|
vadorovsky
approved these changes
Jan 3, 2025
| .method(Method::GET) | ||
| .uri(uri) | ||
| .body(Either::Right(Empty::<Bytes>::new())) | ||
| .map_err(|err| anyhow!("Error building the request. Reason: {}", err))?; |
There was a problem hiding this comment.
Super nit, something to handle in a separate PR: I think it would be better to use thiserror and return specific errors in such cases, especially since it's a client crate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #234