Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore module-level calls in assert_call #409

Merged
merged 4 commits into from
Nov 21, 2023
Merged

Ignore module-level calls in assert_call #409

merged 4 commits into from
Nov 21, 2023

Conversation

angelikatyborska
Copy link
Member

Resolves #378

jiegillet
jiegillet approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@jiegillet jiegillet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every time I stop looking at that codebase for a while and come back I get frightened about how complex it is :)

Looks good, the only change that I would suggest would be to add a test with the code that triggered the comment in the original issue.

@angelikatyborska
Copy link
Member Author

Every time I stop looking at that codebase for a while and come back I get frightened about how complex it is :)

I have the same 🙈 I'm just glad we have so many unit tests. It makes modifying the "compiler" modules less scary.

@angelikatyborska angelikatyborska merged commit bf1d881 into main Nov 21, 2023
6 checks passed
@angelikatyborska angelikatyborska deleted the ignore-module-level-calls-in-assert-call branch November 21, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiegillet jiegillet jiegillet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DNA Encoding should only complain about using builtin iteration constructs only in function bodies
2 participants
@angelikatyborska @jiegillet