Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add analyzer for community-garden #411

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Add analyzer for community-garden #411

merged 2 commits into from
Nov 21, 2023

Conversation

angelikatyborska
Copy link
Member

Inspired by exercism/elixir#1368

This analyzer check ensures that Agent.get_and_update is used instead of Agent.get followed by Agent.update like I've seen in some community solutions.

Website-copy PR: exercism/website-copy#2300

@angelikatyborska angelikatyborska mentioned this pull request Nov 19, 2023
Merged
jiegillet
jiegillet approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@jiegillet jiegillet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice simple little check, back to basics :)

lib/elixir_analyzer/test_suite/community_garden.ex Outdated Show resolved Hide resolved
@angelikatyborska @jiegillet
Update lib/elixir_analyzer/test_suite/community_garden.ex
43bb136 
Co-authored-by: Jie <jie.gillet@gmail.com>
@angelikatyborska angelikatyborska merged commit f1c76d0 into main Nov 21, 2023
6 checks passed
@angelikatyborska angelikatyborska deleted the community-garden-analysis branch November 21, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiegillet jiegillet jiegillet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@angelikatyborska @jiegillet