[New exercise]: resistor-color #16
Conversation
BNAndras
force-pushed
the
add-resistor-color
branch
from
c1d05cf to
987e569
Compare
BNAndras
force-pushed
the
add-resistor-color
branch
from
c437977 to
8dab35a
Compare
|
@pfertyk This is available for review. |
| "uuid": "f8afa182-aca3-4464-96b7-9eb7f8d55449", | ||
| "practices": [], | ||
| "prerequisites": [], | ||
| "difficulty": 2 |
There was a problem hiding this comment.
Do you think that this should be difficulty 2 or 1? (in Python it's 1)
There was a problem hiding this comment.
Up to you as maintainer. My general rule is that exercises of the same difficulty level should be equivalent in difficulty. hello-world would be 1 as the easiest exercise on the track, and resistor-color is more difficult than hello-world so 2 makes sense to me. On the student-facing side, difficulty levels 1 - 3 are all lumped as "easy" so difficulty 1 or 2 doesn't make a difference to them.
There was a problem hiding this comment.
I see ;) In my opinion, if leap is level 1, than this also should be, but I'm not going to insist ;) Level 2 is OK for now, there will be probably some cleanup involved right before the release, so if something changes, we can update the difficulty then.
| return [false, solution_script.color_code("black")] | ||
|
|
||
| func test_color_codes_white(solution_script): | ||
| return [false, solution_script.color_code('white"')] |
There was a problem hiding this comment.
There is a small typo here, making us look for white" instead of white. After fixing it, I believe we should compare the result to 9 instead of false.
What worries me a bit is the fact that my test runner should detect if the type of variables is different (e.g. int vs bool) and fail in that case. But if your tests are passing, then something went wrong ...
No description provided.