Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update square-root description.md #2495

Merged
merged 22 commits into from
Nov 7, 2024
Merged

Update square-root description.md #2495

merged 22 commits into from
Nov 7, 2024

Conversation

@xanni xanni requested a review from a team as a code owner November 5, 2024 05:49
Copy link
Contributor

github-actions bot commented Nov 5, 2024

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Nov 5, 2024
@glennj glennj changed the title Update description.md Update square-root description.md Nov 5, 2024
@Cool-Katt Cool-Katt reopened this Nov 6, 2024
exercises/square-root/description.md Outdated Show resolved Hide resolved
exercises/square-root/description.md Outdated Show resolved Hide resolved
exercises/square-root/description.md Outdated Show resolved Hide resolved
Copy link
Member

@kotp kotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good.

exercises/square-root/introduction.md Outdated Show resolved Hide resolved
exercises/square-root/introduction.md Outdated Show resolved Hide resolved
exercises/square-root/introduction.md Outdated Show resolved Hide resolved
exercises/square-root/instructions.md Outdated Show resolved Hide resolved
exercises/square-root/instructions.md Outdated Show resolved Hide resolved
exercises/square-root/instructions.md Outdated Show resolved Hide resolved
exercises/square-root/instructions.md Outdated Show resolved Hide resolved
xanni and others added 5 commits November 7, 2024 09:37
Co-authored-by: Isaac Good <IsaacG@users.noreply.github.com>
Co-authored-by: Isaac Good <IsaacG@users.noreply.github.com>
Co-authored-by: Isaac Good <IsaacG@users.noreply.github.com>
Copy link
Member

@BethanyG BethanyG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This look good to me in its current state.

exercises/square-root/instructions.md Outdated Show resolved Hide resolved
exercises/square-root/instructions.md Outdated Show resolved Hide resolved
exercises/square-root/introduction.md Outdated Show resolved Hide resolved
@tasxatzial
Copy link
Member

tasxatzial commented Nov 7, 2024

I'd like to point out that both wiki links provide code implementations, with the second link offering even more examples. Someone reading these could unintentionally come across the solution.

@maintainers Is this ok? If the intention is to read the wiki pages, then we are basically asking them to read the solution.

It also seems that all suggested methods refer to the integer square root wiki, so it should be sufficient to keep only that link.

@xanni Please, don't act on my review yet.

xanni and others added 2 commits November 7, 2024 15:10
Co-authored-by: Victor Goff <keeperotphones@gmail.com>
Co-authored-by: Victor Goff <keeperotphones@gmail.com>
@xanni
Copy link
Contributor Author

xanni commented Nov 7, 2024

I'd like to point out that both wiki links provide code implementations, with the second link offering even more examples. Someone reading these could unintentionally come across the solution.

@maintainers Is this ok? If the intention is to read the wiki pages, then we are basically asking them to read the solution.

My understanding is that (particularly for exercises marked as "easy"!) we are happy for students to implement existing solutions in the language of their track and not necessarily expecting them to develop mathematical algorithms from first principles.

@xanni
Copy link
Contributor Author

xanni commented Nov 7, 2024

The wiki link includes actual implementations in C but doesn’t appear to have code in any other languages. Are we still okay with that?

Well, we could edit the Wiki page and replace the C with pseudocode...

mostly kidding.

@Cool-Katt
Copy link
Contributor

I'm feeling

The wiki link includes actual implementations in C but doesn’t appear to have code in any other languages. Are we still okay with that?

I'm feeling okay with that. As I said before, it's much more likely that students would copy existing community solutions, than read the actual wiki page.

@tasxatzial
Copy link
Member

I’m more concerned about students who will spend time reading the wiki. If we direct them to exactly what they’re trying to implement, it takes away their opportunity to develop this themselves.

@xanni
Copy link
Contributor Author

xanni commented Nov 7, 2024

I’m more concerned about students who will spend time reading the wiki. If we direct them to exactly what they’re trying to implement, it takes away their opportunity to develop this themselves.

That's a reasonable concern, but of course students can also copy-and-paste from Stack Overflow, or ask an AI to write it for them... or to take us right back to what started this whole proposal, many of them are just calling sqrt() or n^0.5.

@Cool-Katt
Copy link
Contributor

I’m more concerned about students who will spend time reading the wiki. If we direct them to exactly what they’re trying to implement, it takes away their opportunity to develop this themselves.

If all the effort makes students really read the wiki page and try to understand, then i feel it is time well spent. It's like when you are preparing a cheat sheet for a test, you're revising the material so you and up remembering more.

@xanni
Copy link
Contributor Author

xanni commented Nov 7, 2024

I'm actually OK with deleting all the Wikipedia links (which are full of lots of math notation) and letting enterprising students find that themselves if they want. The implementation hints should be sufficient to provide some handy search terms.

@tasxatzial
Copy link
Member

Copying from Stack Overflow or asking AI implies an intentional choice by students—they know they’re not putting in the effort. That’s very different from directing them to read a page that contains the solution. We expect them to do that in order to learn how the algorithm works. But they have no way of knowing in advance that the wiki includes solutions.

@Cool-Katt
Copy link
Contributor

Well, if they end up looking up the wiki page themselves, it's the same result so it's not less intentional

@xanni xanni requested a review from tasxatzial November 7, 2024 09:04
@tasxatzial
Copy link
Member

@xanni Please hold on a sec. Let's give everyone the chance to catch up.

@IsaacG
Copy link
Member

IsaacG commented Nov 7, 2024

I'm not a fan of removing the Wiki links. If we're asking students to implement an algorithm, we should be providing them with the algorithm details.

@IsaacG
Copy link
Member

IsaacG commented Nov 7, 2024

Could you please put the Wiki links back for now. If you'd like to discuss removing them, please start a new thread on the forum. Let's please restrict the scope of this PR to what was agreed upon in the forum and not expand the scope.

@Cool-Katt
Copy link
Contributor

Could you please put the Wiki links back for now. If you'd like to discuss removing them, please start a new thread on the forum. Let's please restrict the scope of this PR to what was agreed upon in the forum and not expand the scope.

100% agree with Isaac. Let's tackle the links in a separate thread and PR.

@tasxatzial
Copy link
Member

I'm not a fan of removing the Wiki links. If we're asking students to implement an algorithm, we should be providing them with the algorithm details.

That's true; we can't suggest specific algorithms in the description without providing links to them. We definitely don't want people to start Googling and landing on pages at random.

@xanni The whole point of this discussion was to ensure that everyone is fully aware of what we're doing here. Nothing more.

Copy link
Member

@tasxatzial tasxatzial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor changes for consistency.

exercises/square-root/instructions.md Outdated Show resolved Hide resolved
exercises/square-root/introduction.md Outdated Show resolved Hide resolved
xanni and others added 3 commits November 8, 2024 03:35
Co-authored-by: Anastasios Chatzialexiou <16361161+tasxatzial@users.noreply.github.com>
Co-authored-by: Anastasios Chatzialexiou <16361161+tasxatzial@users.noreply.github.com>
exercises/square-root/instructions.md Outdated Show resolved Hide resolved
exercises/square-root/introduction.md Outdated Show resolved Hide resolved
@Cool-Katt Cool-Katt merged commit 0e138d7 into exercism:main Nov 7, 2024
7 checks passed
@xanni xanni deleted the patch-1 branch November 7, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants