Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test to dominoes for uniform reversing #2512

Conversation

monsterkrampe
Copy link

@monsterkrampe monsterkrampe commented Dec 21, 2024

Also see here and here.

I came across a student's solution that would essentially only check that any numbers for two adjacent dominoes match. In essence that means that a domino can be used reversed and unreversed at the same time. The solution still had a special handling for the singleton case, which is why it was not caught by the singleton domino test already present.
This test invalidates such a solution.

Feedback on this PR is much appreciated :)

Copy link
Contributor

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link&category=support ) to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Dec 21, 2024
@monsterkrampe monsterkrampe changed the title Add test to dominoes for uniform order swapping Add test to dominoes for uniform reversing Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant