Add tests for dataclasses that use Slots and Keyword-Only options. #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
…into dataclasses
|
The test is failing on this PR because of code like this, @dataclass(slots=True) #***
class Record:
record_id: int
parent_id: int = field(kw_only=True)Perhaps I don't have access to the latest update that fixed this issue. I'm a bit stuck. |
|
I'll take a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A test is added to verify that the new dataclass features, slots and kw_only, can be parsed by the Representer.
The three examples used are: sgf_parsing, go_counting, and tree_building. They were chosen because their solutions already use dataclasses, making it easier to demonstrate the new features.