v3: fix WithHttpClient name (#661)

# Description - deprecate `WithHttpClient` - add `WithHTTPClient` Use the same initialism as `ClientOptWithHTTPClient`.
exoscale · Sep 24, 2024 · 75ebcdc · 75ebcdc
1 parent 35cad98
commit 75ebcdc
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/v3/client.go b/v3/client.go
diff --git a/v3/generator/client/client.tmpl b/v3/generator/client/client.tmpl
@@ -192,6 +192,7 @@ func (c *Client) WithTrace() *Client {
 }
 
 // WithHttpClient returns a copy of Client with new http.Client.
+// Deprecated: use WithHTTPClient instead.
 func (c *Client) WithHttpClient(client *http.Client) *Client {
 	clone := cloneClient(c)
 
@@ -200,6 +201,15 @@ func (c *Client) WithHttpClient(client *http.Client) *Client {
 	return clone
 }
 
+// WithHTTPClient returns a copy of Client with new http.Client.
+func (c *Client) WithHTTPClient(client *http.Client) *Client {
+	clone := cloneClient(c)
+
+	clone.httpClient = client
+
+	return clone
+}
+
 // WithRequestInterceptor returns a copy of Client with new RequestInterceptors.
 func (c *Client) WithRequestInterceptor(f ...RequestInterceptorFn) *Client {
 	clone := cloneClient(c)