egoscale: update to v3.1.0 and fix #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
| @@ -333,8 +333,7 @@ func (d *controllerService) ControllerUnpublishVolume(ctx context.Context, req * | |||
|
|
|||
| op, err := client.DetachBlockStorageVolume(ctx, volumeID) | |||
| if err != nil { | |||
| if errors.Is(err, v3.ErrNotFound) || | |||
| (errors.Is(err, v3.ErrInvalidRequest) && strings.Contains(err.Error(), "Volume not attached")) { | |||
| if errors.Is(err, v3.ErrNotFound) || strings.Contains(err.Error(), "Volume not attached") { | |||
There was a problem hiding this comment.
Are you now aware of which HTTP code the API is returning? ErrInvalidRequest before was a code range.
Anyway, just checking the error text should be enough for now.
There was a problem hiding this comment.
I don't know. IMO the correct one for the API to return is ErrNotFound, if it's not that the API is incorrect IMO. But for user friendliness, let's keep the check on the error string as a fallback. Should be good.
pierre-emmanuelJ
approved these changes
Jul 17, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
(For exoscale contributors)