This repository has been archived by the owner on Oct 23, 2019. It is now read-only.
Export specific type(user, group, channel) #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lonami
reviewed
Aug 12, 2018
| elif dialog.is_channel: | ||
| dialogType = 'channel' | ||
| else: | ||
| dialogType = 'unknown!' |
There was a problem hiding this comment.
This is generally not good. Also it's impossible that this happens.
Lonami
reviewed
Aug 12, 2018
| dialogType = 'channel' | ||
| else: | ||
| dialogType = 'unknown!' | ||
| if dialogType in dialog_to_dump: |
There was a problem hiding this comment.
String comparison? It's better if you have something like user_enabled, and check if dialog.user and dialog.user_enabled, or something.
Lonami
reviewed
Aug 12, 2018
| # dialog type to download. Options are: | ||
| # "user", "group", "channel". | ||
| # An empty list (default if omitted) means all are allowed. | ||
| DialogWhitelist = user, group, channel |
There was a problem hiding this comment.
Perhaps DialogFilter fits better since we're filtering the type of the dialogs.
Lonami
suggested changes
Aug 12, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pull request for #78
user is able to select which type of chat to export(user, group, channel).