fix: handle definitions from xdl schema properly (#25)

* chore: update the schema definitions to latest version * fix: place definitions to the root of the schema
expo · Sep 30, 2020 · 7afdc86 · 7afdc86
1 parent a6df107
commit 7afdc86
Show file tree

Hide file tree

Showing 4 changed files with 542 additions and 996 deletions.
diff --git a/src/manifest/schema.ts b/src/manifest/schema.ts
@@ -11,6 +11,7 @@ export type ManifestSchema = {
   version: string;
   additionalProperties: true;
   required: string[];
+  definitions?: any;
   properties: {
     expo: any;
   };
@@ -48,12 +49,19 @@ export function createFromXdl(sdkVersion: string, xdlSchema: JsonSchema): Manife
     enhancedSchema = xdlSchema;
   }
 
+  // note: we need to move over definitions from the schema and put them into root
+  const { definitions } = enhancedSchema;
+  if (definitions) {
+    delete enhancedSchema.definitions;
+  }
+
   return {
     $schema: 'http://json-schema.org/draft-07/schema#',
     type: 'object',
     version: sdkVersion,
     additionalProperties: true,
     required: ['expo'],
+    definitions,
     properties: {
       expo: enhancedSchema,
     },