Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add 404 page #1690

Open
wants to merge 2 commits into
base: gh-pages
Choose a base branch
from
Open

add 404 page #1690

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8738fc4
add 404 page
bjohansebas Nov 21, 2024
ac26575
apply suggestions from code review
bjohansebas Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions 404.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
---
layout: 404
title: Page not found
description: We couldn’t find the page you’re looking for.
lang: en
---

# {{ page.title }}

We couldn’t find the page you’re looking for. Check the address or [head back home](/).

If this is a mistake, [let us know](https://github.com/expressjs/expressjs.com/issues/new/), and we will try to fix it!
18 changes: 18 additions & 0 deletions _layouts/404.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
<!DOCTYPE html>

<html lang="en">
{% include head.html %}

{% if page.lang == 'en' %}
<body class="en-doc">
{% else %}
<body class="non-en-doc">
{% endif %}
{% include header/header-{{ page.lang }}.html %}
<div id="overlay"></div>
<main class="content-404">
{{ content }}
</main>
{% include footer/footer-{{ page.lang }}.html %}
</body>
</html>
13 changes: 13 additions & 0 deletions css/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -878,6 +878,19 @@ h2 a {
border-color: #333;
}

.content-404 {
height: 70vh;
padding: 153px 32px 7%;
text-align: center;
display: flex;
justify-content: center;
flex-direction: column;
}

.content-404 p {
font-size: 16px;
}

/* search-bar desktop re-sizing */
@media all and (min-width: 950px) {
.algolia-autocomplete {
Expand Down