Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint: default template to standard #226

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pickfire
Copy link

Time to use standard in generator expressjs/discussions#18

@dougwilson
Copy link
Contributor

Thanks! Can the CI use standard to validate that the generated apps are valid as well? Especially as the other PRs begin to get merged it would be ideal to know if the generated app is still valid or not if it's going to have a specific style.

@pickfire
Copy link
Author

@dougwilson I have added test for lint but not sure why it does not fail even if there's an extra semi-colon.

@dougwilson
Copy link
Contributor

Probably due to the error displayed in our CI:

Error: No ESLint configuration found.

You would need to add the eslint configuration for standard for it to validate it against that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants