Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert to ES2015 #280

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Convert to ES2015 #280

wants to merge 3 commits into from

Conversation

redaktice
Copy link

Update templates to use const and arrow functions.
Update test JS files to use ES2015 syntax

Inspired by #252

@dougwilson dougwilson added the pr label Oct 1, 2020
@gfeller
Copy link

gfeller commented Oct 5, 2020

Have been waiting a long time for this change.
Any chance that this pull request gets merged?

@dougwilson
Copy link
Contributor

Hi @gfeller , can you ellaborate on the goal of this PR? It seems to change the style of both the internal generator code and the templated code. Is this desired?

There is nothing wrong with adding a newer es templated code that is an option to the generator, of course, though it doesn't seem like this PR keeps the old format around still under such an option.

The actual generator code it seems to no longer follow the StandardJS format, which we require our org projects to follow, like this one was doing before. Does StandardJS prevent the change to the new style or something?

dougwilson
dougwilson suggested changes Oct 7, 2020
View reviewed changes
Copy link
Contributor

@dougwilson dougwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Internal generator code must follow StandardJS style.

Converting to ES2015, inspired by georgie105
768e82a 
More cleanup

updating linters and more fixes

Updating travis ci and removing lint errors

Updating CI test runner and eslint for console logs

Working on mocha tests, because context is a thing

More mild approach

Updating version and more ES2015 conversion
@redaktice
Copy link
Author

Internal generator code must follow StandardJS style.

No problem @dougwilson, I made the change back to the StandardJS format

This was referenced May 27, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougwilson dougwilson Awaiting requested review from dougwilson

Assignees
No one assigned
Labels
pr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@redaktice @gfeller @dougwilson