Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding JSX (React) as an option for the view engine in express #281

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Reshav-Paul
Copy link

The Express official docs list react as an option for the view engine using the express-react-views module.
This pull request adds jsx as an option for the view engine from the CLI using --view = jsx.

Commits have been made for -

  1. Adding CLI support for jsx.
  2. Default jsx templates
  3. Tests to validate its working.
  4. Updated README to include jsx

@Reshav-Paul
Copy link
Author

Builds are failing on older versions of nodejs. It is passing fine otherwise.

@dougwilson
Copy link
Contributor

Thank you! Do not worry about the failing older Node.js versions for this, as it does pass fine on the newer versions. I am adding a method to target a given Node.js version for the upcoming version, so this template would just fit in by requiring a minimum target version.

@Reshav-Paul
Copy link
Author

That would be great! Thanks for the update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants