Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add prisma model and prisma field attr #40

Merged
merged 3 commits into from
Nov 4, 2023
Merged

Conversation

rsaz
Copy link
Member

@rsaz rsaz commented Nov 1, 2023

Pull Request Guidelines

Our guidelines for submitting a pull request.

Before submitting a Pull Request, please make sure you have verified the following:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

PR Type

What kind of change does this PR introduce?

  • Documentation fix
  • Documentation update
  • New Feature
  • Translation:: New language
  • Bugfix
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Please describe the current behavior that you are modifying, or link to a relevant issue.
Issue Number: N/A

-> Response:

What is the new behavior?

Describe the new behavior or link to a relevant issue.

-> Response: added prisma provider documentation

Does this PR introduce a breaking change?

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications below.

-> Response:

Other information

Any other information that is important to this PR.

  • N/A

-> Response:

@ghost
Copy link

ghost commented Nov 1, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

feat(prisma.mdx): update Prisma Provider documentation with new installation instructions and usage examples

chore(docusaurus.config.js): update dark code theme to use vsDark theme instead of dracula theme
@Daniel-Boll
Copy link
Contributor

@rsaz, I've made some tweaks to the doc, but it's not done yet. Could you take a look to see if it's going in the right direction style-wise? Also, I changed the dark theme in the code snippets to see how it looks. I felt the Dracula theme was a bit off from our site colors. What do you think?

@rsaz
Copy link
Member Author

rsaz commented Nov 2, 2023

@rsaz, I've made some tweaks to the doc, but it's not done yet. Could you take a look to see if it's going in the right direction style-wise? Also, I changed the dark theme in the code snippets to see how it looks. I felt the Dracula theme was a bit off from our site colors. What do you think?

Hi @Daniel-Boll , you're heading to the right direction. I loved the new visual, tabs, coding examples. All this combined with mermaids really looks cool. After you put all the doc for Prisma there I will review to see if is there any functionality missing then we can merge this PR.

I will also have to restructure the entire documentation to match this new visual style applied which I liked. Let me know about the updates.

@rsaz rsaz added the doc update Update of documentation label Nov 2, 2023
…k-plugin-npm2yarn plugin for npm to yarn conversion in code blocks

chore(package.json): add @docusaurus/remark-plugin-npm2yarn as a dependency for npm to yarn conversion in code blocks
@Daniel-Boll
Copy link
Contributor

@rsaz I've included the documentation for the Relation and Index decorators; please let me know your thoughts! Regarding the update of the documentation to the new visuals, I'm pleased you liked it. We can identify some issues and collaborate on addressing them!

@rsaz rsaz removed their assignment Nov 4, 2023
@rsaz rsaz merged commit 58d5128 into main Nov 4, 2023
1 check passed
@rsaz rsaz deleted the feature/prisma-provider branch November 4, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc update Update of documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants