Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cargo deny to audit licenses of dependencies #15

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Add cargo deny to audit licenses of dependencies #15

merged 1 commit into from
Aug 31, 2023

Conversation

expressvpn-mariappan-r
Copy link
Contributor

Changes:

  • Add deny.toml which cargo-deny uses to check license
  • Add earthly target check-license for checking licenses
  • Update github actions to run this target on all PRs

@CLAassistant
Copy link

CLAassistant commented Aug 30, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

expressvpn-mariappan-r
expressvpn-mariappan-r commented Aug 30, 2023
View reviewed changes
deny.toml Outdated Show resolved Hide resolved
deny.toml Outdated Show resolved Hide resolved
@expressvpn-mariappan-r expressvpn-mariappan-r force-pushed the add-cargo-deny branch 2 times, most recently from d6afb77 to 2e03aeb Compare August 30, 2023 07:09
@expressvpn-mariappan-r expressvpn-mariappan-r changed the title [LIT-37] Add cargo deny to audit licenses of dependencies Add cargo deny to audit licenses of dependencies Aug 30, 2023
expressvpn-ian-c
expressvpn-ian-c reviewed Aug 30, 2023
View reviewed changes
Copy link
Contributor

@expressvpn-ian-c expressvpn-ian-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One specific comment here, but the general comments from expressvpn/wolfssl-sys#40 mostly apply too.

deny.toml Outdated Show resolved Hide resolved
@expressvpn-mariappan-r
Add cargo deny to audit licenses of dependencies
a02fd68 
- Add earthly target `check-license` for checking licenses
- Update github actions to `cargo deny licenses sources bans` on every pr excluding advisories
- Add github action nightly job to run `cargo deny` including advisories
@expressvpn-mariappan-r expressvpn-mariappan-r merged commit 60a4b08 into main Aug 31, 2023
4 checks passed
@expressvpn-ian-c expressvpn-ian-c deleted the add-cargo-deny branch September 4, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@expressvpn-ian-c expressvpn-ian-c expressvpn-ian-c approved these changes

@expressvpn-pete-m expressvpn-pete-m Awaiting requested review from expressvpn-pete-m

@expressvpn-brendan-h expressvpn-brendan-h Awaiting requested review from expressvpn-brendan-h

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@expressvpn-mariappan-r @CLAassistant @expressvpn-ian-c