Skip to content

Commit

Permalink
[TASK] Satisfy coding guideline
Browse files Browse the repository at this point in the history
  • Loading branch information
rintisch committed Jun 24, 2024
1 parent bd2ac06 commit 57df458
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions Classes/EventListener/Create/CreateCartProduct.php
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,7 @@

class CreateCartProduct
{
public function __construct(protected DetailPageLinkFactoryInterface $detailPageLinkFactory)
{}
public function __construct(protected DetailPageLinkFactoryInterface $detailPageLinkFactory) {}

Check failure on line 20 in Classes/EventListener/Create/CreateCartProduct.php

View workflow job for this annotation

GitHub Actions / code-quality (8.1, ^12.4)

Parameter $detailPageLinkFactory of method Extcode\CartProducts\EventListener\Create\CreateCartProduct::__construct() has invalid type Extcode\Cart\Domain\Model\Cart\DetailPageLinkFactoryInterface.

Check failure on line 20 in Classes/EventListener/Create/CreateCartProduct.php

View workflow job for this annotation

GitHub Actions / code-quality (8.1, ^12.4)

Property Extcode\CartProducts\EventListener\Create\CreateCartProduct::$detailPageLinkFactory has unknown class Extcode\Cart\Domain\Model\Cart\DetailPageLinkFactoryInterface as its type.

Check failure on line 20 in Classes/EventListener/Create/CreateCartProduct.php

View workflow job for this annotation

GitHub Actions / code-quality (8.2, ^12.4)

Parameter $detailPageLinkFactory of method Extcode\CartProducts\EventListener\Create\CreateCartProduct::__construct() has invalid type Extcode\Cart\Domain\Model\Cart\DetailPageLinkFactoryInterface.

Check failure on line 20 in Classes/EventListener/Create/CreateCartProduct.php

View workflow job for this annotation

GitHub Actions / code-quality (8.2, ^12.4)

Property Extcode\CartProducts\EventListener\Create\CreateCartProduct::$detailPageLinkFactory has unknown class Extcode\Cart\Domain\Model\Cart\DetailPageLinkFactoryInterface as its type.

Check failure on line 20 in Classes/EventListener/Create/CreateCartProduct.php

View workflow job for this annotation

GitHub Actions / code-quality (8.3, ^12.4)

Parameter $detailPageLinkFactory of method Extcode\CartProducts\EventListener\Create\CreateCartProduct::__construct() has invalid type Extcode\Cart\Domain\Model\Cart\DetailPageLinkFactoryInterface.

Check failure on line 20 in Classes/EventListener/Create/CreateCartProduct.php

View workflow job for this annotation

GitHub Actions / code-quality (8.3, ^12.4)

Property Extcode\CartProducts\EventListener\Create\CreateCartProduct::$detailPageLinkFactory has unknown class Extcode\Cart\Domain\Model\Cart\DetailPageLinkFactoryInterface as its type.
public function __invoke(RetrieveProductsFromRequestEvent $event): void
{
$request = $event->getRequest();
Expand Down Expand Up @@ -56,7 +55,7 @@ public function __invoke(RetrieveProductsFromRequestEvent $event): void
$cartProduct->setIsVirtualProduct(true);
}

if($request->getArgument('detailPageUid')){
if ($request->getArgument('detailPageUid')) {
$detailPageLink = $this->detailPageLinkFactory->getDetailPageLink(

Check failure on line 59 in Classes/EventListener/Create/CreateCartProduct.php

View workflow job for this annotation

GitHub Actions / code-quality (8.1, ^12.4)

Call to method getDetailPageLink() on an unknown class Extcode\Cart\Domain\Model\Cart\DetailPageLinkFactoryInterface.

Check failure on line 59 in Classes/EventListener/Create/CreateCartProduct.php

View workflow job for this annotation

GitHub Actions / code-quality (8.2, ^12.4)

Call to method getDetailPageLink() on an unknown class Extcode\Cart\Domain\Model\Cart\DetailPageLinkFactoryInterface.

Check failure on line 59 in Classes/EventListener/Create/CreateCartProduct.php

View workflow job for this annotation

GitHub Actions / code-quality (8.3, ^12.4)

Call to method getDetailPageLink() on an unknown class Extcode\Cart\Domain\Model\Cart\DetailPageLinkFactoryInterface.
(int)$request->getArgument('detailPageUid'),
'cartproducts',
Expand All @@ -66,7 +65,6 @@ public function __invoke(RetrieveProductsFromRequestEvent $event): void
$cartProduct->setDetailPageLink($detailPageLink);

Check failure on line 65 in Classes/EventListener/Create/CreateCartProduct.php

View workflow job for this annotation

GitHub Actions / code-quality (8.1, ^12.4)

Call to an undefined method Extcode\Cart\Domain\Model\Cart\Product::setDetailPageLink().

Check failure on line 65 in Classes/EventListener/Create/CreateCartProduct.php

View workflow job for this annotation

GitHub Actions / code-quality (8.2, ^12.4)

Call to an undefined method Extcode\Cart\Domain\Model\Cart\Product::setDetailPageLink().

Check failure on line 65 in Classes/EventListener/Create/CreateCartProduct.php

View workflow job for this annotation

GitHub Actions / code-quality (8.3, ^12.4)

Call to an undefined method Extcode\Cart\Domain\Model\Cart\Product::setDetailPageLink().
}


$event->setCartProduct($cartProduct);
}
}

0 comments on commit 57df458

Please sign in to comment.