Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar view style & onWheel function apply #274 #275

Merged
merged 3 commits into from
Nov 14, 2024

Conversation

luriusTM
Copy link
Contributor

Now it is applied on a wrapper div, so will not affect the popup, but the calendar.

Rewritten it to override defaults and use in styles only the self made styles.

These was the review comments for the previous style problems. Only some minor style element is not possible this way, but it is not so recognisable.

Current:
image

@eythaann
Copy link
Owner

now the classes are ok, but the style doesn't match with the rest of the app, remove transparency and use a solid color just like it is now without transparency just a plain gray-50.

@eythaann
Copy link
Owner

Also the selected day should have rounder corners, and be solid color.

@eythaann
Copy link
Owner

eythaann commented Nov 11, 2024

also the days that aren't part of the month should be shown, no hidden

@luriusTM
Copy link
Contributor Author

now the classes are ok, but the style doesn't match with the rest of the app, remove transparency and use a solid color just like it is now without transparency just a plain gray-50.

Also the selected day should have rounder corners, and be solid color.

also the days that aren't part of the month should be shown, no hidden

Yes master! :)
image

@eythaann
Copy link
Owner

eythaann commented Nov 12, 2024

Make the header clickable to get the month view just like current implementation allows (if I wanna see the date where I was born for example is hard to fit the date with only the day-to-day view):
image
image
image

@luriusTM
Copy link
Contributor Author

Make the header clickable to get the month view just like current implementation allows (if I wanna see the date where I was born for example is hard to fit the date with only the day-to-day view): image image image

I'm not sure you are right or not... this view is mostly for some short upcoming ones... or at least I use it for maybe for next month, or next year, I do not browse half a decade ago, if I want something like that, I use an outlook or a calendar app. But as you wish:

Screen.Recording.2024-11-13.135620.mp4

And this component do not have a decade view... please do not ask that :D

@eythaann
Copy link
Owner

eythaann commented Nov 14, 2024

hahaha only with the month-to-month is ok, I will merge this, but I will change the styles to fit better with the default theme on the final release.

@eythaann eythaann merged commit 2cee5a5 into eythaann:master Nov 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants