Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IncludeRequiredDataConnectors,OmitDataTypeExtension - requiredDataConnectors to ARM template #35

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Kaloszer
Copy link

@Kaloszer Kaloszer commented May 13, 2024

Adds requiredDataConnectors back to the ARM template - I use it to validate the workspace prior to deployment whether it contains required tables/columns.

IncludeRequiredDataConnectors

Switch to include requiredDataConnectors to the ARM template when converting from yaml

OmitDataTypeExtension

Removes the stuff inside of () and the brackets themselves - as this is not a table name - useless for me, opt in, not default behaviour.

Exec w/ -OmitDataTypeExtension and -IncludeRequiredDataConnectors

image

Exec w/ -IncludeRequiredDataConnectors

image

Also @f-bader where the Pester tests at 😄 ?

@f-bader
Copy link
Owner

f-bader commented May 13, 2024

Nice additional. I will review the PR over the next week but looks really cool

Tests can be found here https://github.com/f-bader/SentinelARConverter/blob/main/tests/Convert-SentinelARYamlToArm.tests.ps1

@f-bader f-bader added enhancement New feature or request good first issue Good for newcomers labels May 24, 2024
@f-bader
Copy link
Owner

f-bader commented May 24, 2024

Hi @Kaloszer thank you very much for the additional functionality. I checked the offical ARM template description and it seems that RequiredDataConnectors is not a valid field.

Have you successfully tested the deployment of an ARM template created this way?

@Kaloszer
Copy link
Author

@f-bader It's not, that's why it's an optional field here. I filter it out in the CD workflow just before it gets sent as an ARM template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants