-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support sub-techniques for newer API versions #38
Conversation
I guess this is only true if the api version is current enough. See #37 |
Double checked the documentation and it's not as easy as to just keep them. There needs to be the container with, and a container without the subrechniques. Minimum API version is indeed "tactics": [
"Reconnaissance"
],
"techniques": [
"T1589",
"T1592",
"T1598"
],
"subTechniques": [
"T1589.001",
"T1592.001"
] @Konverto-MartinGasser do you feel up for the task adding this including tests or rather wait until I have the time to implement it? |
This reverts commit f9906c7.
I was able to implement the function and do some local testing/deploying, which was working as expected. Tomorrow I will try to create matching tests, but honestly, I don't think that I succeed. I'll let you know how it went. |
Very cool. If you need help with the tests let me know. Happy to help |
Hey @f-bader, could you kindly take a look at my changes and especially on those tests I've written? I've never worked with test-files so far so I'm not sure I did the right thing ( at least they are not failing ;) ) Thanks |
Will do but most likely next week |
@Konverto-MartinGasser Amazing work and sorry it took me so long to validate and merge this. |
With commit 3f4ed3c MITRE sub-techniques should be supported and do not require to be removed anymore.