Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADD] state_dict functionality to KFACLinearOperator and KFACInverseLinearOperator #114

Merged
merged 8 commits into from
May 23, 2024
Merged

[ADD] state_dict functionality to KFACLinearOperator and KFACInverseLinearOperator #114

merged 8 commits into from
May 23, 2024

Conversation

runame
Copy link
Collaborator

@runame runame commented May 15, 2024

Resolves #113.

I don't know if this covers all edge cases, but hopefully at least the most common use cases. For example, it is assumed that the user passes the right params, not sure if this can be avoided or if it is likely to lead to problems.

@runame runame added the enhancement New feature or request label May 15, 2024
@runame runame requested a review from f-dangel May 15, 2024 22:32
@runame runame self-assigned this May 15, 2024
@coveralls
Copy link

coveralls commented May 15, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9214642589

Details

  • 62 of 65 (95.38%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 88.74%
Changes Missing Coverage Covered Lines Changed/Added Lines %
curvlinops/kfac.py 44 47 93.62%
Totals Coverage Status
Change from base Build 9198716941: 0.4%
Covered Lines: 1324
Relevant Lines: 1492
💛 - Coveralls

f-dangel
f-dangel reviewed May 23, 2024
View reviewed changes
Copy link
Owner

@f-dangel f-dangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions how to improve the tests

curvlinops/kfac.py Show resolved Hide resolved
curvlinops/kfac.py Show resolved Hide resolved
curvlinops/kfac.py Show resolved Hide resolved
curvlinops/inverse.py Outdated Show resolved Hide resolved
test/test_inverse.py Show resolved Hide resolved
test/test_kfac.py Show resolved Hide resolved
test/test_kfac.py Outdated Show resolved Hide resolved
test/test_kfac.py Outdated Show resolved Hide resolved
test/test_inverse.py Outdated Show resolved Hide resolved
test/test_inverse.py Outdated Show resolved Hide resolved
@runame runame requested a review from f-dangel May 23, 2024 14:36
f-dangel
f-dangel reviewed May 23, 2024
View reviewed changes
test/test_inverse.py Outdated Show resolved Hide resolved
test/test_inverse.py Show resolved Hide resolved
test/test_inverse.py Show resolved Hide resolved
test/test_kfac.py Show resolved Hide resolved
test/test_kfac.py Outdated Show resolved Hide resolved
test/test_kfac.py Show resolved Hide resolved
test/test_kfac.py Outdated Show resolved Hide resolved
@runame runame requested a review from f-dangel May 23, 2024 20:29
f-dangel
f-dangel approved these changes May 23, 2024
View reviewed changes
Copy link
Owner

@f-dangel f-dangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge master into this branch first. This should fix the currently failing RTD CI run. Once that is confirmed, ready to merge.

@runame runame merged commit d509cd6 into main May 23, 2024
13 checks passed
@runame runame deleted the kfac-state-dict branch May 23, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f-dangel f-dangel f-dangel approved these changes

Assignees

@runame runame

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add state_dict functionality to KFACLinearOperator and KFACInverseLinearOperator
3 participants
@runame @coveralls @f-dangel