[FIX] Checks if Enum contains string
#119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 9489624969Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9489631898Details
💛 - Coveralls |
|
Seems like the issue is actually because of a newer version of Python. Your check works in Python 3.8, but fails in Python 3.9 (the default of This works in Python 3.9: In [5]: [v.value for v in FisherType]
Out[5]: ['type-2', 'mc', 'empirical', 'forward-only'] |
|
PS. Python 3.8 will be deprecated soon https://devguide.python.org/versions/. |
|
@wiseodd Have you tried the fix in this PR? I also tested it with Python 3.11 and it worked. |
Pull Request Test Coverage Report for Build 9489716093Details
💛 - Coveralls |
|
Yes, the fix here works. Can't wait to finally free from the shackles of Python < 3.10. Pattern matching, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #118.
Also, I have added the
FisherTypeandKFACTypeEnums to__init__to make them easy to import.