New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Improve numerical stability of Frobenius estimator #120

Merged

f-dangel merged 1 commit into main from improve-frobenius

Jul 3, 2024

Owner

f-dangel commented Jul 2, 2024

Instead of estimating the Frobenius norm by v.T @ (A.T @ A @ v), use w.T @ w where w = A @ v. This

halves the number of matvecs
improves numerical stability (result cannot be negative), and
does not require the linear operator A to define .T.


[REF] Improve numerical stability of Frobenius estimator

c1f5463

coveralls commented Jul 2, 2024 •

edited

Loading

Pull Request Test Coverage Report for Build 9761747142

Details

7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.03%) to 88.896%

Totals
Change from base Build 9490097890:	0.03%
Covered Lines:	1337
Relevant Lines:	1504

💛 - Coveralls

runame approved these changes

View reviewed changes

Collaborator

runame left a comment

Very nice, LGTM!

f-dangel merged commit 4aaec2b into main

13 checks passed

f-dangel deleted the improve-frobenius branch

July 3, 2024 23:47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment