Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC] Add more matrices to visual tour, prettify plots with tueplots #134

Merged
merged 3 commits into from
Oct 25, 2024
Merged

[DOC] Add more matrices to visual tour, prettify plots with tueplots #134

merged 3 commits into from
Oct 25, 2024

Conversation

f-dangel
Copy link
Owner

@f-dangel f-dangel commented Oct 6, 2024

Adds the block-diagonal Hessian, MC-Fisher, and KFAC to the visual tour tutorial.
Prettifies the visualizations using tueplots.

@coveralls
Copy link

coveralls commented Oct 6, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11203632981

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 56 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-3.7%) to 88.786%
Files with Coverage Reduction New Missed Lines %
curvlinops/examples/utils.py 10 31.25%
curvlinops/fisher.py 46 26.47%
Totals Coverage Status
Change from base Build 11001385384: -3.7%
Covered Lines: 1346
Relevant Lines: 1516
💛 - Coveralls

@f-dangel f-dangel requested a review from runame October 6, 2024 16:59
runame
runame approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@runame runame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@f-dangel f-dangel mentioned this pull request Oct 21, 2024
Merged
@f-dangel f-dangel merged commit e366829 into main Oct 25, 2024
13 checks passed
@f-dangel f-dangel deleted the improve-visual-tour branch October 25, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runame runame runame approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@f-dangel @coveralls @runame