Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADD] Support arbitrarily-ordered params in KFAC #51

Merged
merged 9 commits into from
Oct 30, 2023
Merged

[ADD] Support arbitrarily-ordered params in KFAC #51

merged 9 commits into from
Oct 30, 2023

Conversation

f-dangel
Copy link
Owner

Resolves #47.

@f-dangel f-dangel requested a review from runame October 30, 2023 15:59
runame
runame approved these changes Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@runame runame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@f-dangel f-dangel merged commit 4b37a8f into development Oct 30, 2023
13 checks passed
@f-dangel f-dangel deleted the kfac-arbitrary-params-order branch October 30, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runame runame runame approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@f-dangel @runame