Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] Support CrossEntropyLoss in KFAC #52

Merged
merged 8 commits into from
Oct 30, 2023
Merged

Conversation

f-dangel
Copy link
Owner

Closes #44.

As a test, I am considering a data set consisting of a single sample. In that case, the Fisher-blocks are exactly Kronecker-factored, because there is no sum over multiple data points. In the limit of infinite MC-samples, KFAC thus approaches the block-diagonal Fisher.

@f-dangel f-dangel requested a review from runame October 30, 2023 16:08
@github-actions
Copy link

Pull Request Test Coverage Report for Build 6695531317

  • 10 of 11 (90.91%) changed or added relevant lines in 1 file are covered.
  • 40 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-5.1%) to 87.247%

Changes Missing Coverage Covered Lines Changed/Added Lines %
curvlinops/kfac.py 10 11 90.91%
Files with Coverage Reduction New Missed Lines %
curvlinops/examples/utils.py 6 41.67%
curvlinops/fisher.py 34 28.85%
Totals Coverage Status
Change from base Build 6695320687: -5.1%
Covered Lines: 691
Relevant Lines: 792

💛 - Coveralls

Copy link
Collaborator

@runame runame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the potential minor performance improvement in my comment, LGTM.

curvlinops/kfac.py Show resolved Hide resolved
@f-dangel f-dangel merged commit b3d7463 into development Oct 30, 2023
13 checks passed
@f-dangel f-dangel deleted the kfac-ce-loss branch October 30, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants