-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REF] Implement _matmat
instead of _matvec
#73
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes a lot of sweeps through the data set if a linear operator is applied onto multiple vectors in parallel.
Pull Request Test Coverage Report for Build 7818184673
💛 - Coveralls |
Ready for review. |
runame
approved these changes
Feb 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might be missing something because I'm not that familiar with the code for the non-KFAC linear operators, but everything looks good to me and the tests are all passing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning: This is a big refactoring and it will require some iterations to reduce complexity.
Please complain about anything that is incomprehensible, and check for outdated/unclear docstrings.
Currently, all linear operators implement how to multiply with a single vector (
_matvec
).Multiplying onto more than one vector is simply iterating over the vectors one by one (
_matmat
).This adds a lot of sweeps through a data set which can be avoided by implementing matrix-matrix,
rather than matrix-vector multiplication.
This PR changes the base class implementation from
_matvec
to_matmat
.