[FIX] Incorporate suggestions

f-dangel · Nov 8, 2023 · 44ba969 · 44ba969
1 parent d4c9921
commit 44ba969
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/singd/optim/optimizer.py b/singd/optim/optimizer.py
@@ -559,7 +559,7 @@ def _register_tensor_hook_on_output_to_accumulate_H_terms(
     ):
         """Register a tensor hook on the module's output that accumulates the H terms.
 
-        This function can be used as a `full_backward_hook`.
+        This function can be used as a `forward_hook`.
 
         Only installs the hook for steps matching the specified update frequency.
 

diff --git a/test/optim/test_inplace_activations.py b/test/optim/test_inplace_activations.py
@@ -13,7 +13,7 @@
 from singd.optim.optimizer import SINGD
 
 
-@mark.parametrize("inplace", [True, False], ids=["inplace=True", "inplce=False"])
+@mark.parametrize("inplace", [True, False], ids=["inplace=True", "inplace=False"])
 def test_hooks_support_inplace_activations(inplace: bool):
     """Test that SINGD's hooks support in in-place activations.
 
@@ -52,7 +52,7 @@ def test_compare_training_using_inplace_activations(reduction: str):
 
     # _inplace indicates that the trained net has in-place activations
 
-    # NOTE All parameters of this net are supported by SINGD, no optimizer is involved
+    # NOTE All parameters of this net are supported by SINGD
     model = Sequential(
         Conv2d(1, 3, kernel_size=5, stride=2),
         ReLU(),