Skip to content

Commit

Permalink
[DOC] Add arXiv link to KFAC for modern NN architectures paper (#57)
Browse files Browse the repository at this point in the history
  • Loading branch information
runame authored Nov 2, 2023
1 parent 7578f3b commit e045f6e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions singd/optim/optimizer.py
Original file line number Diff line number Diff line change
Expand Up @@ -156,8 +156,8 @@ def __init__(
or `Linear` modules that process matrix- or higher-dimensional
features.
Possible values are `'expand'` and `'reduce'`.
See [Eschenhagen et al., 2023](TODO Insert arXiv link) for an
explanation of the two approximations.
See [Eschenhagen et al., 2023](https://arxiv.org/abs/2311.00636)
for an explanation of the two approximations.
warn_unsupported: Only relevant if `params` is unspecified. Whether to
warn if `model` contains parameters of layers that are not supported.
These parameters will not be trained by the optimizer. Default: `True`
Expand Down
4 changes: 2 additions & 2 deletions test/optim/test_kfac.py
Original file line number Diff line number Diff line change
Expand Up @@ -100,8 +100,8 @@ def test_kfac(
):
"""Test KFAC using (deep) linear models with weight sharing and the MSE loss.
See [Eschenhagen et al., 2023](TODO Insert arXiv link) for more details on
the conditions for KFAC being exact.
See [Eschenhagen et al., 2023](https://arxiv.org/abs/2311.00636) for more
details on the conditions for KFAC-expand and KFAC-reduce being exact.
Args:
model: Tuple of model name and function takes `bias` as input and
Expand Down

0 comments on commit e045f6e

Please sign in to comment.