Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REF] Average channel groups before unfolding #59

Merged
merged 1 commit into from
Nov 2, 2023
Merged

[REF] Average channel groups before unfolding #59

merged 1 commit into from
Nov 2, 2023
+5 −5

Conversation

f-dangel
Copy link
Owner

@f-dangel f-dangel commented Nov 2, 2023

Resolves #58 and should significantly reduce memory and FLOPS for grouped convolutions.

@f-dangel f-dangel requested a review from runame November 2, 2023 12:59
runame
runame approved these changes Nov 2, 2023
View reviewed changes
Copy link
Collaborator

@runame runame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@f-dangel f-dangel merged commit 125ff06 into main Nov 2, 2023
14 checks passed
@f-dangel f-dangel deleted the average-before-unfold branch November 2, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runame runame runame approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve _extract_patches for grouped convolutions
2 participants
@f-dangel @runame