[ADD] Use TN formulation of Dangel, 2023 to compute average patches #61
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #60.
I added a test that ensures the TN formulation computes faster and uses less memory than the previous approach.
There are still more performance improvements possible for structured convolutions, but I first need to put more work into the
einconv
library's simplification mechanism before we can make those even faster and more memory-efficient.Here is the output of the test case (CPU):