Implementation of Job Website Crawling #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f-lab-lyan
reviewed
Feb 3, 2024
f-lab-lyan
reviewed
Feb 15, 2024
|
|
||
| private final PyhonRunner pyhonRunner; | ||
|
|
||
| @Scheduled(cron = "0 0 12 * * ?") |
There was a problem hiding this comment.
좀 더 서비스가 한가한 시간에 하면 좋지 않을까요? :-)
f-lab-lyan
reviewed
Feb 15, 2024
| } | ||
|
|
||
| @Test | ||
| void runMyPythonRunner() throws IOException { |
There was a problem hiding this comment.
좀 더 제대로 테스트를 하고 싶으면, 어떻게 할 수 있을까요?
f-lab-lyan
reviewed
Feb 15, 2024
|
|
||
| private Process runPythonCrawling() throws IOException, InterruptedException { | ||
| ProcessBuilder pythonBuilder = new ProcessBuilder( | ||
| "python3","../crawling/src/main/python/crawl_job_website.py" |
There was a problem hiding this comment.
jar로 묶으면, "../crawling/src/main/python/crawl_job_website.py" 경로가 없기 때문에 실패할 텐데요. 이걸 어떻게 해결할 수 있을지 생각해보시면 좋을 것 같습니다.
힌트는 gradle에서 빌드를 할 때, python의 빌드결과를 먼저 app의 resource에 넣어주면, jar에 들어가게 되고, https://www.baeldung.com/spring-classpath-file-access#resource-utils 등을 사용해서 python 파일을 읽으면 됩니다.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용