Minor Refactoring and Documentation Update #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkiryanov
commented
Feb 27, 2024
There was a problem hiding this comment.
@f213 тут мелкие изменения.
Причина что сделал PR это мелкие ошибки (их подсветил в комментариях), ну и если начал, то заодно решил добавить линтер + подправить то, на что он обращает внимание.
shellcheck использую давно, очень им доволен — помогает избежать многих ошибок новичка когда пишу скрипты + встроен в github actions
f213
approved these changes
Feb 28, 2024
There was a problem hiding this comment.
Мне всё нравки.
Раз уж взялись за линтеры, я бы хотел в будущем затащить ещё hadolint и docker-image-size-limit. Задачи запилил.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor Refactoring and Documentation Update:
shellcheck.