-
-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add an option to control the discretization of colormap #1678
Open
gapry
wants to merge
7
commits into
f3d-app:master
Choose a base branch
from
gapry:issue-228
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
249321f
Add CLI option to discretize colormap
gapry 4899fc1
[PoC][Part02]: Add CLI option to discretize colormap
gapry 68a0dbc
change option type from bool to vector<double>
gapry 5df8019
change option type from vector<double> to int
gapry dd9c2b8
fix: the default value of discretization is 256
gapry 7ebcd86
use F3DColoringInfoHandler to replace the vtkF3DMetaImporter::Colori…
gapry c3ec7ae
remove the log of PoC
gapry File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,6 +14,7 @@ | |
#include "vtkF3DMetaImporter.h" | ||
#include "vtkF3DUIActor.h" | ||
|
||
#include <vtkDiscretizableColorTransferFunction.h> | ||
#include <vtkLight.h> | ||
#include <vtkOpenGLRenderer.h> | ||
|
||
|
@@ -282,6 +283,11 @@ class vtkF3DRenderer : public vtkOpenGLRenderer | |
*/ | ||
void SetColormap(const std::vector<double>& colormap); | ||
|
||
/** | ||
* Set the discretization of the colormap | ||
*/ | ||
void SetColorDiscretization(const int discretization); | ||
|
||
/** | ||
* Set the meta importer to recover coloring information from | ||
*/ | ||
|
@@ -557,6 +563,10 @@ class vtkF3DRenderer : public vtkOpenGLRenderer | |
vtkF3DMetaImporter* Importer = nullptr; | ||
vtkMTimeType ImporterTimeStamp = 0; | ||
|
||
vtkNew<vtkDiscretizableColorTransferFunction> DiscretizableColorTransferFunction; | ||
bool DiscretizableColorTransferFunctionConfigured = false; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I dont think you need this |
||
int Discretization = 256; | ||
|
||
vtkNew<vtkScalarBarActor> ScalarBarActor; | ||
bool ScalarBarActorConfigured = false; | ||
|
||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you do that directly on the existing colorTransferFunction
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can.