Feature: Read EXR files from memory #1733
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Meakk
reviewed
Nov 26, 2024
|
|
||
| std::string actual_filename = std::string(argv[1]) + "data/Rec709.exr"; | ||
| std::string filename = "readFromMem.exr"; | ||
| reader->SetFileName(filename.c_str()); |
There was a problem hiding this comment.
I don't think the filename should be set here.
| { | ||
| if (pos + n <= bufflen) | ||
| { | ||
| memcpy(c, buffer + pos, n); |
There was a problem hiding this comment.
Let's use C++ here (you may need to include algorithm instead of cstring)
Suggested change
| memcpy(c, buffer + pos, n); | |
| std::copy_n(buffer + pos, n, c); |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1733 +/- ##
==========================================
- Coverage 96.96% 95.69% -1.27%
==========================================
Files 110 118 +8
Lines 8825 9368 +543
==========================================
+ Hits 8557 8965 +408
- Misses 268 403 +135 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
This work addresses the Issue: #1187
Description
This PR continues the work initiated by Nabiel Kandiel in PR #1448.