-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: print packages' timestamp in job 'install' #2674
Conversation
52b058e
to
34ff630
Compare
Would be great to print the full URL too? |
Maybe a candidate for the new job summary stuff - https://github.blog/2022-05-09-supercharging-github-actions-with-job-summaries/? |
Since there are several URLs and all of them have a similar syntax, I don't think it's worth. The main use case is to update the date and hash used in a for loop: https://github.com/chipsalliance/f4pga-examples/pull/300/files. I.e., it's a matter of copying two values. Copying the full URL is not helpful in that case.
|
That's a very interesting feature! Thanks for the reference! However, I feel it to be out of scope of this PR. I'd like to address #2675, #2676 and #2673 before generating reports/summaries. |
Signed-off-by: Unai Martinez-Corral <umartinezcorral@antmicro.com>
Signed-off-by: Unai Martinez-Corral <umartinezcorral@antmicro.com>
Signed-off-by: Unai Martinez-Corral <umartinezcorral@antmicro.com>
34ff630
to
e3f409f
Compare
@mithro I did some tests with GITHUB_STEP_SUMMARY in hdl/containers. There seem to be issues when using composite actions, because the summaries are overwritten. See, for instance, https://github.com/hdl/containers/actions/runs/2355254788. However, it looks quite nice if the content is written from a "regular" step. Therefore, I added printing the timestamp and the hash in the summary.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Packages are uploaded to GCS through
gsutil cp ${package} gs://${GCP_PATH}/${TIMESTAMP}/
. Unfortunately, the target is hidden in the logs:https://github.com/SymbiFlow/f4pga-arch-defs/runs/6472094719?check_suite_focus=true#step:4:24660
Therefore, users cannot guess the URL of the arch-def packages generated by some specific commit. They know the format, they know the hash, but they don't know the specific timestamp. This PR prints it.
Ref chipsalliance/f4pga-examples#292