Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add landing page #2

Merged
merged 4 commits into from
Oct 24, 2023
Merged

feat: add landing page #2

merged 4 commits into from
Oct 24, 2023

Conversation

iverly
Copy link
Member

@iverly iverly commented Oct 23, 2023

This PR adds the landing page for the documentation website.

@iverly iverly added enhancement New feature or request good first issue Good for newcomers labels Oct 23, 2023
@iverly iverly self-assigned this Oct 23, 2023
@netlify
Copy link

netlify bot commented Oct 23, 2023

Deploy Preview for faast-rt ready!

Name Link
🔨 Latest commit 0eb0abc
🔍 Latest deploy log https://app.netlify.com/sites/faast-rt/deploys/653769a625d32b0007e0880f
😎 Deploy Preview https://deploy-preview-2--faast-rt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100
Accessibility: 96
Best Practices: 100
SEO: 83
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@alexis-langlet alexis-langlet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add space on top of the big title so that you only see that when you land on the page ?

Also, in the sentence:
"Experience seamless integration, swift deployments, and a robust ecosystem designed to supercharge your applications. Elevate your serverless journey with us."
Seems a bit too much, could you please change the "a robust ecosystem designed to supercharge your applications" part pls?

The dark mode is maybe a bit too black and that looks weird.

Other than that it's perfect, really good work!

Signed-off-by: iverly <github@iverly.net>
Signed-off-by: iverly <github@iverly.net>
Signed-off-by: iverly <github@iverly.net>
Signed-off-by: iverly <github@iverly.net>
@iverly iverly force-pushed the feat/add-landing-page branch from a13f574 to 0eb0abc Compare October 24, 2023 06:52
@iverly
Copy link
Member Author

iverly commented Oct 24, 2023

Could you please add space on top of the big title so that you only see that when you land on the page ?

Also, in the sentence: "Experience seamless integration, swift deployments, and a robust ecosystem designed to supercharge your applications. Elevate your serverless journey with us." Seems a bit too much, could you please change the "a robust ecosystem designed to supercharge your applications" part pls?

The dark mode is maybe a bit too black and that looks weird.

Other than that it's perfect, really good work!

Changes done, the dark mode will be fixed in the future since it's not the priority right now. (and it's working)

@iverly iverly requested a review from alexis-langlet October 24, 2023 06:55
Copy link

@alexis-langlet alexis-langlet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me!
Really nice job, thank you

@iverly iverly merged commit 5f7ec92 into main Oct 24, 2023
4 checks passed
@iverly iverly deleted the feat/add-landing-page branch October 24, 2023 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants