Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Factor mir rvalue/lvalue builders into one single builder #209

Open
fabianschuiki opened this issue Oct 26, 2020 · 0 comments
Open

Factor mir rvalue/lvalue builders into one single builder #209

fabianschuiki opened this issue Oct 26, 2020 · 0 comments
Labels
A-mir Area: Mid-level Intermediate Representation. C-cleanup Category: Clean up or refactor code. E-easy Call for Participation: Easy issue, good first issue. L-vlog Language: Verilog and SystemVerilog.

Comments

@fabianschuiki
Copy link
Owner

The lower::rvalue::Builder and lower::lvalue::Builder structs are identical, except for their handling of build. Factor these out into a single lower::Builder, with separate build_rvalue and build_lvalue functions.
@fabianschuiki fabianschuiki added C-cleanup Category: Clean up or refactor code. E-easy Call for Participation: Easy issue, good first issue. L-vlog Language: Verilog and SystemVerilog. A-mir Area: Mid-level Intermediate Representation. labels Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-mir Area: Mid-level Intermediate Representation. C-cleanup Category: Clean up or refactor code. E-easy Call for Participation: Easy issue, good first issue. L-vlog Language: Verilog and SystemVerilog.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fabianschuiki