Properly consider that a method containing ... is an empty method and…

… don't report unused arguments in it.
fabioz · Oct 1, 2023 · 6eb37eb · 6eb37eb
1 parent 8d835ea
commit 6eb37eb
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 0 deletions.
diff --git a/...ins/com.python.pydev.analysis/src/com/python/pydev/analysis/visitors/MessagesManager.java b/...ins/com.python.pydev.analysis/src/com/python/pydev/analysis/visitors/MessagesManager.java
@@ -348,6 +348,13 @@ public void addUnusedMessage(SimpleNode node, Found f) {
                                 if (expr.value instanceof Str) {
                                     continue;
                                 }
+                                if (expr.value instanceof Name) {
+                                    Name name = (Name) expr.value;
+                                    if ("...".equals(name.id)) {
+                                        continue;
+                                    }
+
+                                }
                             }
                             addMessage = true;
                             break;

diff --git a/...g.python.pydev/tests_analysis/com/python/pydev/analysis/OccurrencesAnalyzerPy310Test.java b/...g.python.pydev/tests_analysis/com/python/pydev/analysis/OccurrencesAnalyzerPy310Test.java
@@ -707,4 +707,21 @@ public void testTypingWithLiterals() {
                 + "");
         checkNoError();
     }
+
+    public void testOverload() {
+        doc = new Document("from typing import overload\n"
+                + "\n"
+                + "\n"
+                + "class C:\n"
+                + "    @overload\n"
+                + "    def foo(self, a: int) -> None: ...\n"
+                + "\n"
+                + "    @overload\n"
+                + "    def foo(self, a: str) -> None: ...\n"
+                + "\n"
+                + "    def foo(self, a: int | str) -> None:\n"
+                + "        print(a)  # dummy impl"
+                + "");
+        checkNoError();
+    }
 }