Check if offset is valid before using it. The offset might be invalid…

… when a user clicks on a location which is after the last character of a line
fabioz · Feb 7, 2024 · a1b4ed4 · a1b4ed4
1 parent f388151
commit a1b4ed4
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/plugins/org.python.pydev/src/org/python/pydev/editor/PyInformationPresenter.java b/plugins/org.python.pydev/src/org/python/pydev/editor/PyInformationPresenter.java
@@ -202,11 +202,10 @@ public String updatePresentation(Drawable drawable, String hoverInfo, TextPresen
 
                 @Override
                 public void mouseDown(MouseEvent e) {
-                    int offset;
-                    try {
-                        offset = styledText.getOffsetAtPoint(new Point(e.x, e.y));
-                    } catch (IllegalArgumentException e1) {
-                        return; //invalid location
+                    int offset = styledText.getOffsetAtPoint(new Point(e.x, e.y));
+                    if (offset == -1) {
+                        // invalid location
+                        return;
                     }
                     StyleRange r = styledText.getStyleRangeAtOffset(offset);
                     if (r instanceof PyStyleRange) {