Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always initialize preference defaults using the extension point #241

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

torokati44
Copy link
Contributor

@torokati44 torokati44 commented Dec 6, 2018

This aims to solve https://www.brainwy.com/tracker/PyDev/956.

The problem was that calling the initializeDefaultPreferences() methods manually (directly) caused the defaults loaded from plugin_customization.ini to be overridden. According to the documentation, this should never be done, and using the extension point is the (only) proper way.

Now, there were comments I deleted, saying something about backward compatibility. What exactly are those about? Are they still relevant today?

I also renamed some constants that had confusing names, just for consistency's sake.

@fabioz
Copy link
Owner

fabioz commented Oct 11, 2019

I'm sorry about the long delay in getting back to you on this issue... are you still interested in solving the conflicts to have that change incorporated?

@torokati44
Copy link
Contributor Author

I think we were able to work around this problem somehow since, so it's no longer that urgent for us, but doing things properly is always nicer IMHO.
Having this merged would perhaps make our code simpler too, but it's not a priority anymore. So, it's up to you...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants