Merge pull request #3602 from fable-compiler/fix/python_toString

Fix #3601: Fix calling `value.ToString(CultureInfo.InvariantCulture)`
fable-compiler · Nov 20, 2023 · 13ed2a1 · 13ed2a1
2 parents 5d6eeed + 7d76685
commit 13ed2a1
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/src/Fable.Cli/CHANGELOG.md b/src/Fable.Cli/CHANGELOG.md
@@ -32,6 +32,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 * Fixed char to string type regression with binary operator (by @dbrattli)
 * Fix `DateTime(..., DateTimeKind.Local).ToString("O")` (by @MangelMaxime)
+* Fix calling `value.ToString(CultureInfo.InvariantCulture)` (by @MangelMaxime)
 
 ## 4.5.0 - 2023-11-07
 

diff --git a/src/Fable.Transforms/Python/Replacements.fs b/src/Fable.Transforms/Python/Replacements.fs
@@ -2245,7 +2245,7 @@ let parseNum (com: ICompiler) (ctx: Context) r t (i: CallInfo) (thisArg: Expr op
         Helper.LibCall(com, "string", "format", t, [ format; thisArg.Value ], [ format.Type; thisArg.Value.Type ], ?loc = r)
         |> Some
     | "ToString", _ ->
-        Helper.GlobalCall("String", String, [ thisArg.Value ], ?loc = r)
+        Helper.GlobalCall("str", String, [ thisArg.Value ], ?loc = r)
         |> Some
     | _ -> None
 

diff --git a/tests/Python/TestString.fs b/tests/Python/TestString.fs
@@ -888,3 +888,9 @@ let ``test Can create FormattableString`` () =
 [<Fact>]
 let ``test printing strings with unicode characters`` () =
     printfn "🚀 printing unicode ..."
+
+[<Fact>]
+let ``test calling ToString(CultureInfo.InvariantCulture) works`` () =
+    (1).ToString(CultureInfo.InvariantCulture) |> equal "1"
+    (7923209L).ToString(CultureInfo.InvariantCulture) |> equal "7923209"
+    (7923209UL).ToString(CultureInfo.InvariantCulture) |> equal "7923209"