Add support for IndexOf with index and StringComparison

fable-compiler · Nov 29, 2023 · 7a9d703 · 7a9d703
1 parent d0f600e
commit 7a9d703
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/src/Fable.Transforms/Replacements.fs b/src/Fable.Transforms/Replacements.fs
@@ -2550,6 +2550,7 @@ let strings
         | [ ExprType String ]
         | [ ExprType Char; ExprType(Number(Int32, NumberInfo.Empty)) ]
         | [ ExprType String; ExprType(Number(Int32, NumberInfo.Empty)) ]
+        | [ ExprType String; StringComparisonEnumValue ]
         | [ ExprType String
             ExprType(Number(Int32, NumberInfo.Empty))
             StringComparisonEnumValue ] ->

diff --git a/tests/Js/Main/StringTests.fs b/tests/Js/Main/StringTests.fs
@@ -720,6 +720,10 @@ let tests =
             |> equal 4
 
       testCase "String.IndexOf with StringComparison" <| fun () ->
+            "abcdbc".IndexOf("b", StringComparison.Ordinal)
+            |> equal 1
+
+      testCase "String.IndexOf with index and StringComparison" <| fun () ->
             "abcdbc".IndexOf("b", 3, StringComparison.Ordinal)
             |> equal 4
 
@@ -732,6 +736,10 @@ let tests =
             |> equal 1
 
       testCase "String.LastIndexOf with StringComparison" <| fun () ->
+            "abcdbc".LastIndexOf("b", StringComparison.Ordinal)
+            |> equal 4
+
+      testCase "String.LastIndexOf with index and StringComparison" <| fun () ->
             "abcdbc".LastIndexOf("b", 3, StringComparison.Ordinal)
             |> equal 1