Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiling as library #3561

Merged
merged 31 commits into from
Dec 12, 2023
Merged

Compiling as library #3561

Show file tree
Hide file tree
Changes from 27 commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
5744ea6
Proof of concept
nojaf Oct 21, 2023
e6f7f7b
Find dependent files after compilation.
nojaf Oct 25, 2023
85b0a02
Use FCS from lib.
nojaf Oct 28, 2023
7cd3061
GetDependentFiles from Compiler.
nojaf Oct 28, 2023
45a672e
Pass sourceReader as dependency.
nojaf Oct 28, 2023
b19b89a
Rename Fable.Compiler.Service to Fable.Compiler
nojaf Oct 28, 2023
caa121a
Update CodeServices API in respect to vite-plugin requirements.
nojaf Nov 1, 2023
cc7fcf1
Further rename to Fable.Compiler.
nojaf Nov 1, 2023
d516fa2
The current file is part of the dependentFiles
nojaf Nov 2, 2023
9dd09b8
Rather unknown WIP stage.
nojaf Nov 22, 2023
d007f97
Move ProjectCracker and utils to Fable.Compiler
nojaf Nov 22, 2023
219fec9
Add custom FCS dlls
nojaf Nov 22, 2023
059eba0
Use FCS from fcs/nojaf directory.
nojaf Nov 25, 2023
c052350
Fix namespace in Compiler Tests.
nojaf Nov 27, 2023
bc8224b
Use Globbing from Fable.Compiler.
nojaf Nov 27, 2023
e0453ab
Format (mostly new) code
nojaf Nov 27, 2023
4bb019b
Remove StringBuilder from BabelWriter
nojaf Nov 27, 2023
b07c958
Include signature file for Util.
nojaf Dec 1, 2023
049e7c2
Clean up ProjectCracker.fsi
nojaf Dec 1, 2023
1e55d67
Remove GetDependentFiles call.
nojaf Dec 1, 2023
36b0703
Don't pass checker in CompilerImpl.
nojaf Dec 2, 2023
2a01222
Add MSBuild properties to pack Fable.Compiler.
nojaf Dec 2, 2023
8e7091a
Apply fixes of analyzers.
nojaf Dec 6, 2023
537b496
Remove temporary sample project.
nojaf Dec 6, 2023
fa4072f
Remove unwanted changes.
nojaf Dec 6, 2023
621c8cf
Remove custom binaries.
nojaf Dec 11, 2023
6d94eea
Add requirements to release Fable.Compiler
MangelMaxime Dec 12, 2023
57fc8af
Embedded pdb
nojaf Dec 12, 2023
fe1b257
Merge branch 'carve-out' of https://github.com/nojaf/Fable into carve…
nojaf Dec 12, 2023
b3923f9
Remove FSharp.DependencyManager.Nuget.dll reference
nojaf Dec 12, 2023
51b7876
Remove old signature file.
nojaf Dec 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Fable.sln
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,8 @@ Project("{F2A71F9B-5D33-465A-A702-920D77279786}") = "Fable.Tests.Spaces", "tests
EndProject
Project("{F2A71F9B-5D33-465A-A702-920D77279786}") = "Fable.Build", "src\Fable.Build\Fable.Build.fsproj", "{F2E323CE-FDF3-4A1E-AE97-B723D2E63763}"
EndProject
Project("{F2A71F9B-5D33-465A-A702-920D77279786}") = "Fable.Compiler", "src\Fable.Compiler\Fable.Compiler.fsproj", "{942DD29B-07C0-4ACF-891E-85C1235A9BE0}"
EndProject
Global
GlobalSection(SolutionConfigurationPlatforms) = preSolution
Debug|Any CPU = Debug|Any CPU
Expand Down Expand Up @@ -160,6 +162,10 @@ Global
{F2E323CE-FDF3-4A1E-AE97-B723D2E63763}.Debug|Any CPU.Build.0 = Debug|Any CPU
{F2E323CE-FDF3-4A1E-AE97-B723D2E63763}.Release|Any CPU.ActiveCfg = Release|Any CPU
{F2E323CE-FDF3-4A1E-AE97-B723D2E63763}.Release|Any CPU.Build.0 = Release|Any CPU
{942DD29B-07C0-4ACF-891E-85C1235A9BE0}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{942DD29B-07C0-4ACF-891E-85C1235A9BE0}.Debug|Any CPU.Build.0 = Debug|Any CPU
{942DD29B-07C0-4ACF-891E-85C1235A9BE0}.Release|Any CPU.ActiveCfg = Release|Any CPU
{942DD29B-07C0-4ACF-891E-85C1235A9BE0}.Release|Any CPU.Build.0 = Release|Any CPU
EndGlobalSection
GlobalSection(SolutionProperties) = preSolution
HideSolutionNode = FALSE
Expand Down Expand Up @@ -189,6 +195,7 @@ Global
{F9134F40-C6CD-4368-A28E-33E5102FD4AB} = {CF0A8EC3-841F-4A54-B9FC-8D174CCD4A90}
{C90E23AF-4B5B-44A7-ADCC-3BF89547395B} = {DA29278E-3808-42DE-8333-964F129F295D}
{F2E323CE-FDF3-4A1E-AE97-B723D2E63763} = {C8CB96CF-68A8-4083-A0F8-319275CF8097}
{942DD29B-07C0-4ACF-891E-85C1235A9BE0} = {C8CB96CF-68A8-4083-A0F8-319275CF8097}
EndGlobalSection
GlobalSection(ExtensibilityGlobals) = postSolution
SolutionGuid = {58DF9285-8523-4EAC-B598-BE5B02A76A00}
Expand Down
1 change: 1 addition & 0 deletions src/Fable.Build/Publish.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,7 @@ let handle (args: string list) =

publishNuget ProjectDir.fableAst
publishNuget ProjectDir.fableCore
publishNuget ProjectDir.fableCompiler
publishNuget ProjectDir.fableCli
publishNuget ProjectDir.fablePublishUtils

Expand Down
1 change: 1 addition & 0 deletions src/Fable.Build/Workspace.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ module ProjectDir =
let fableCore = Path.Resolve("src", "Fable.Core")
let fableCli = Path.Resolve("src", "Fable.Cli")
let fablePublishUtils = Path.Resolve("src", "Fable.PublishUtils")
let fableCompiler = Path.Resolve("src", "Fable.Compiler")
let temp_fable_library = Path.Resolve("temp", "fable-library")
let fable_library = Path.Resolve("src", "fable-library")
let fable_metadata = Path.Resolve("src", "fable-metadata")
Expand Down
1 change: 1 addition & 0 deletions src/Fable.Cli/Entry.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ module Fable.Cli.Entry
open System
open Main
open Fable
open Fable.Compiler.Util

type CliArgs(args: string list) =
let argsMap =
Expand Down
5 changes: 1 addition & 4 deletions src/Fable.Cli/Fable.Cli.fsproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,11 +50,7 @@
<Content Include="..\fable-library-php\**\*.*" PackagePath="fable-library-php\" />
</ItemGroup>
<ItemGroup>
<Compile Include="Util.fsi" />
<Compile Include="Util.fs" />
<Compile Include="Contributors.fs" />
<Compile Include="Globbing.fs" />
<Compile Include="ProjectCracker.fs" />
<Compile Include="Printers.fs" />
<Compile Include="FileWatchers.fsi" />
<Compile Include="FileWatchers.fs" />
Expand All @@ -65,6 +61,7 @@
<Content Include="Properties\launchSettings.json" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="..\Fable.Compiler\Fable.Compiler.fsproj" />
<ProjectReference Include="..\Fable.Transforms\Fable.Transforms.fsproj" />
<Reference Include="../../lib/fcs/FSharp.Compiler.Service.dll" />
<Reference Include="../../lib/fcs/FSharp.DependencyManager.Nuget.dll" />
Expand Down
2 changes: 1 addition & 1 deletion src/Fable.Cli/FileWatchers.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ open System.Threading
open System.Collections.Generic
open System.Diagnostics
open System.Text.RegularExpressions
open Fable.Cli.Globbing
open Fable.Compiler.Globbing

type IFileSystemWatcher =
inherit IDisposable
Expand Down
Loading
Loading